Skip to content

glibc: 2.34-210 -> 2.35-163#182538

Merged
Ma27 merged 1 commit intostagingfrom
glibc-2.35
Jul 26, 2022
Merged

glibc: 2.34-210 -> 2.35-163#182538
Ma27 merged 1 commit intostagingfrom
glibc-2.35

Conversation

@lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Jul 23, 2022

Description of changes

The patches needed a little work, but other than that it was pretty smooth. I
built hello successfully, but we'll need Hydra to do further checking.

cc. @vcunat

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Jul 23, 2022

See also #165979.

@lovesegfault lovesegfault requested review from Ma27, ajs124, trofi and vcunat and removed request for Ma27 July 23, 2022 06:07
@lovesegfault
Copy link
Member Author

lovesegfault commented Jul 23, 2022

Built up to python3 without issues.

@ofborg ofborg bot added the 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. label Jul 23, 2022
@ofborg ofborg bot requested a review from edolstra July 23, 2022 07:09
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 23, 2022
@lovesegfault
Copy link
Member Author

lovesegfault commented Jul 23, 2022

Built up to firefox without issues: /nix/store/zln8r9iyxpann0gv9wv8l65s3nchar6m-firefox-102.0.1/

@lovesegfault
Copy link
Member Author

lovesegfault commented Jul 23, 2022

Built up to Chromium: /nix/store/6cmscp0wlssv6mr5zql6lnv5yx4ad6h5-chromium-103.0.5060.134/

@vcunat
Copy link
Member

vcunat commented Jul 23, 2022 •
edited
Loading

Nit: in the patches of #!/bin/bash, why don't we make that hunk to have no context, so that we don't have to update it every year? The risk of applying it wrongly seems pretty non-existent here.

trofi
trofi approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In past few months I built my desktop system with glibc-2.35 a few times and did not notice major API breakages. Should be an easy hydra run (famous last words).

@Ma27
Copy link
Member

Ma27 commented Jul 23, 2022

Yeah, the releases from February are IIRC the less impactful ones :)
Anyways, I'm going to close #165979 now since this is more up-to-date and seems to be working fine.

@lovesegfault just one thing: it would be cool if we could coordinate who takes care of glibc updates in the future to make sure we don't duplicate work :)

@lovesegfault
Copy link
Member Author

lovesegfault commented Jul 23, 2022

Alright, I built all of iso_gnome without issues. I think it's in a good state.

@lovesegfault
Copy link
Member Author

lovesegfault commented Jul 23, 2022

@lovesegfault just one thing: it would be cool if we could coordinate who takes care of glibc updates in the future to make sure we don't duplicate work :)

Definitely, I completely forgot that we had a branch for 2.35 up, so when I hit a need for it yesterday, I decided to just try bumping it.

@ghost ghost mentioned this pull request Jul 24, 2022
Merged
5 tasks
@ghost
Copy link

ghost commented Jul 24, 2022

This bootstraps on powerpc64le-linux with a bootstrap-files rebuilt after #181943. And it looks like it will let us use IEEE-standard long double like Fedora 36 does: #170215.

@vcunat
Copy link
Member

vcunat commented Jul 25, 2022

Hydra jobset, as requested through matrix: https://hydra.nixos.org/jobset/nixpkgs/pr-182538-glibc-2.35

@lovesegfault
Copy link
Member Author

lovesegfault commented Jul 26, 2022

Okay, the eval isn't fully done, but it's far enough along that I don't think we have any major noticeable issues with this PR.

@Ma27 Do you oppose merging it and letting it cook in staging? Don't want to hit the button without your OK.

Ma27
Ma27 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks!

@Ma27 Ma27 merged commit 7774b5b into staging Jul 26, 2022
@Ma27 Ma27 deleted the glibc-2.35 branch July 26, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Ma27 approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@ajs124 ajs124 Awaiting requested review from ajs124

@edolstra edolstra Awaiting requested review from edolstra

+1 more reviewer

@trofi trofi trofi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lovesegfault @Ma27 @vcunat @trofi